potiuk opened a new pull request, #9:
URL: https://github.com/apache/airflow-steward/pull/9

   ## Summary
   
   The repo was leaking four GitHub event streams to `[email protected]` 
because those schemes were unset in our `notifications:` block — and ASF Infra 
defaults any unset scheme to `dev@<project>.apache.org`.
   
   ## Root cause
   
   Per the ASF asf.yaml validator at 
[`apache/infrastructure-asfyaml`](https://github.com/apache/infrastructure-asfyaml/blob/main/asfyaml/feature/notifications.py),
 `VALID_NOTIFICATION_SCHEMES` includes **eleven** schemes for a public GitHub 
repo:
   
   ```
   commits             issues                pullrequests
   commits_by_path     issues_status         pullrequests_status
   discussions         issues_comment        pullrequests_comment
   jobs                jira_options          (+ bot-pattern variants)
   ```
   
   Our previous config set five (`commits`, `issues`, `pullrequests`, `jobs`, 
`discussions`). The four GitHub-event streams **`issues_status`, 
`issues_comment`, `pullrequests_status`, `pullrequests_comment`** were unset, 
so every issue label change, every issue comment, every PR state change + CI 
status check failure, and every PR comment was being routed to 
`[email protected]`. `pullrequests_status` is by far the noisiest of 
these — it fires on every CI status-check failure across every PR.
   
   (`commits_by_path` is an optional path-specific override and is 
intentionally left unset; `jira_options` is for Jira-integrated repos.)
   
   For reference, `apache/airflow` itself has the same five-field shape and is 
presumably leaking the same four streams to `[email protected]` — that's 
a separate fix to propose there.
   
   ## What this PR does
   
   - Adds explicit routes for the four leaking schemes — same target as the 
rest (`[email protected]`), the standard Airflow PMC bot-event mirror 
list.
   - Reformats the field list with column alignment so a missing scheme is 
visually obvious in future diffs.
   - Expands the comment to spell out the dev@ default behaviour, links the 
schema source, and notes the rationale for the `[email protected]` 
target.
   
   ## Diff
   
   `.asf.yaml`, `+33 −5`. Four new field lines + comment expansion. The five 
existing routes are unchanged.
   
   ## Test plan
   
   - ✅ `prek` passes (no doctoc / EOF / line-ending changes).
   - ASF Infra's `.asf.yaml` processor is the verifier — it will either accept 
the new schemes (silently good) or reject the file with a validation error 
(visible in the gitbox notification email to `[email protected]`).
   - After merge, watch `[email protected]` for an absence of 
`apache-airflow-steward` issue/PR notifications over the next ~week.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to