john-jac commented on PR #66035:
URL: https://github.com/apache/airflow/pull/66035#issuecomment-4344656215

   Thanks @SameerMesiah97 and @vincbeck for the review! Addressed all feedback:
   
   1. Moved guardrail tests into `test_bedrock.py` (no separate file)
   2. Added hook unit tests for `get_guardrail_id_by_name` (`test_found` + 
`test_not_found`)
   3. Unhappy path tests already added: `test_execute_fail_on_conflict` and 
`test_execute_skip_existing_not_found`
   4. Operator uses `hook.get_guardrail_id_by_name()` instead of inline 
paginator


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to