bbovenzi commented on code in PR #63884:
URL: https://github.com/apache/airflow/pull/63884#discussion_r3162782465
##########
airflow-core/src/airflow/ui/openapi-gen/requests/types.gen.ts:
##########
@@ -1880,6 +1881,7 @@ export type ConfigResponse = {
external_log_name?: string | null;
theme: Theme | null;
multi_team: boolean;
+ rerun_with_latest_version: boolean;
Review Comment:
We see the result here. We never end up with a null or undefined config
state so the UI fallback never happens.
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/config.py:
##########
@@ -62,6 +62,7 @@ def get_configs() -> ConfigResponse:
"external_log_name": getattr(task_log_reader.log_handler, "log_name",
None),
"theme": loads(conf.get("api", "theme", fallback="{}")) or None,
"multi_team": conf.getboolean("core", "multi_team"),
+ "rerun_with_latest_version": conf.getboolean("core",
"rerun_with_latest_version", fallback=False),
Review Comment:
I just did some manual testing. We are forcing the value to be false right
here so then backfills will never default to True in the UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
