wjddn279 opened a new pull request, #66141:
URL: https://github.com/apache/airflow/pull/66141

    ### Problems
   
   #### 1. Workload token leaks into callback supervisor's runtime API calls
   
   related https://github.com/apache/airflow/pull/60108, When the executor 
enqueues an ExecuteCallback, the supervisor receives a long-lived 
`workload`-scoped token (intended only as a one-time admission ticket, like for 
ExecuteTask). However, unlike ExecuteTask — which immediately swaps it for an 
`execution`-scoped token via PATCH /task-instances/{id}/run — 
supervise_callback never performs the swap. It carries the `workload` token 
straight through into runtime API calls (e.g. Connection.get(), Variable.get()).
   
   ```
   2026-04-29T11:08:35.766821Z [warning  ] Token type not allowed for endpoint 
[airflow.api_fastapi.execution_api.security] allowed_types=['execution'] 
correlation_id=019dd8ed-2e34-7b0d-bfba-d7fe16612411 loc=security.py:174 
path=/execution/connections/slack_default token_scope=workload
   2026-04-29T11:08:35.767466Z [info     ] request finished               
[http.access] client_addr=172.18.0.7:47640 duration_us=1634 
loc=http_access_log.py:98 method=GET path=/execution/connections/slack_default 
query= status_code=403
   ```
   These shared endpoints only accept execution-scoped tokens, so any callback 
that touches Connections or Variables hits 403 from require_auth's scope check.
   
   #### 2. process_executor_events is the only writer of callback state, and 
it's executor-specific
   
     Today, callback state transitions (QUEUED → RUNNING → SUCCESS/FAILED) are 
written only by the scheduler's _process_executor_events, which reads from each 
executor's in-process event_buffer. It does not work for executors that don't 
use the scheduler's in-process event channel — most notably EdgeExecutor, where 
workers run on remote machines and report back via HTTP. Their callbacks stay 
forever in QUEUED.
   
   ### Solution
   
   Move callback state transitions to the Execution API, mirroring the 
ExecuteTask pattern:
   
   - `POST /callbacks/{id}/run` — accepts both workload and execution tokens; 
transitions QUEUED → RUNNING and returns a fresh execution token via the 
Refreshed-API-Token header (same swap mechanism PR #60108 introduced for TI). 
All subsequent callback API calls use the execution token.
   - `PATCH /callbacks/{id}/state` — execution-only; records the terminal 
SUCCESS / FAILED outcome with optional output.
   - `supervise_callback` calls `client.callbacks.start()` before forking the 
subprocess and `client.callbacks.finish()` afterward, so the API is the single 
source of truth for callback
      state — works uniformly across all executors (Local, Celery, Kubernetes, 
Edge).
   - `_process_executor_events` keeps its callback handling as a forward-only 
fallback for cases where the supervisor crashes before reporting a terminal 
state; it never regresses a state already advanced by the API.
   
   <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [x] Yes (please specify the tool below)
   claude code (opus 4.7) to make test codes
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to