xBis7 commented on code in PR #66151:
URL: https://github.com/apache/airflow/pull/66151#discussion_r3168208312
##########
task-sdk/src/airflow/sdk/execution_time/comms.py:
##########
@@ -193,9 +206,16 @@ class CommsDecoder(Generic[ReceiveMsgType, SendMsgType]):
# Async lock for async operations
_async_lock: asyncio.Lock = attrs.field(factory=asyncio.Lock, repr=False)
+ def _make_frame(self, msg: SendMsgType) -> _RequestFrame:
+ carrier: dict[str, str] = {}
+ _trace_propagator.inject(carrier)
+ return _RequestFrame(
+ id=next(self.id_counter), body=msg.model_dump(),
traceparent=carrier.get("traceparent")
Review Comment:
It works with just the `traceparent` but why not pass the entire carrier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
