o-nikolas commented on PR #63035:
URL: https://github.com/apache/airflow/pull/63035#issuecomment-4354508260
> > Thanks for the continued engagement on this one @SameerMesiah97!
> > Since @ferruzzi is out, I'm checking in on this one. I trust Dennis on
the code review front, but have you done manual testing in a while? There have
been a lot of changes. If you could do some quick UAT to ensure the code is al
behaving how you expect then I'll be happy to merge! Also, testing with the
oldest version of Airflow that providers support (2.11.0) would be helpful too,
to test all the back compat logic.
>
> @o-nikolas
>
> I have used a production image for a local live deployment using the
latest code in my local branch (rebased on top of main) to execute the
following DAG successfully::
>
> ```
> from datetime import datetime
>
> from airflow import DAG
> from airflow.operators.bash import BashOperator
>
>
> def success_callback(context):
> print("Callback executed! Task succeeded.")
> print(f"Task: {context['task_instance_key_str']}")
>
> with DAG(
> dag_id="lambda_executor_smoke",
> start_date=datetime(2024, 1, 1),
> schedule=None,
> catchup=False,
> ) as dag:
>
> test_task = BashOperator(
> task_id="test_task",
> bash_command="echo 'Hello from Lambda Executor' && exit 0",
> on_success_callback=success_callback
> )
> ```
>
> Additionally, I used the base image for 2.11.0 and installed a local
distribution based on the amazon provider code in my local branch (rebased on
top of main). I can confirm that there are no compatibility issues and that the
backwards compatibility shims are functional.
Lovely! Thanks for doing the testing :smiley:
Given @ferruzzi's "approval"
>I am heading on vacation tomorrow so you can consider this my approval once
that fix is done..
I'll approve and merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
