kaxil opened a new pull request, #66192:
URL: https://github.com/apache/airflow/pull/66192

   ## Summary
   
   PR #66144 added a `while job.is_running: await sleep(0.1)` polling loop in 
`providers/edge3/src/airflow/providers/edge3/cli/worker.py:557` to ensure the 
supervisor task has fully ended after results were grabbed from the queue. This 
trips ruff's ASYNC110 lint and is **currently failing the static-checks job on 
every PR built against `main`** (e.g., [run 
25191627167](https://github.com/apache/airflow/actions/runs/25191627167/job/73865339152)).
   
   ## Fix
   
   Apply the same pattern PR #66157 used for 
[`RedshiftDataTrigger`](https://github.com/apache/airflow/pull/66157/files): 
refactor `while X: await sleep(...)` to `while True: if not X: break; await 
sleep(...)`. Same behaviour, ASYNC110-clean.
   
   ```diff
           # Ensure that supervisor really ended after we grabbed results from 
queue
   -       while job.is_running:
   -           await sleep(0.1)
   +       while True:
   +           if not job.is_running:
   +               break
   +           await sleep(0.1)
   ```
   
   The proper fix (signalling completion via `asyncio.Event` from the 
supervisor instead of polling) is a larger refactor and can land separately.
   
   ## Why this matters now
   
   Every PR's `CI image checks / Static checks` job currently fails on this 
rule. 
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [ ]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to