amoghrajesh commented on code in PR #66073: URL: https://github.com/apache/airflow/pull/66073#discussion_r3173363504
########## airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_state.py: ########## @@ -0,0 +1,238 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from typing import TYPE_CHECKING +from uuid import uuid4 + +import pytest +from sqlalchemy import delete, select + +from airflow._shared.timezones import timezone +from airflow.models.dagrun import DagRun +from airflow.models.task_state import TaskStateModel +from airflow.utils.session import create_session + +if TYPE_CHECKING: + from fastapi.testclient import TestClient + + from tests_common.pytest_plugin import CreateTaskInstance + +pytestmark = pytest.mark.db_test + + [email protected](autouse=True) +def reset_state_tables(): + with create_session() as session: + session.execute(delete(TaskStateModel)) + session.execute(delete(DagRun)) + + +def _api_url(ti_id, key: str | None = None) -> str: + base = f"/execution/state/ti/{ti_id}" + return f"{base}/{key}" if key else base + + +class TestGetTaskState: + def test_get_returns_value(self, client: TestClient, create_task_instance: CreateTaskInstance): + ti = create_task_instance() + client.put(_api_url(ti.id, "job_id"), json={"value": "spark_001"}) + + response = client.get(_api_url(ti.id, "job_id")) + + assert response.status_code == 200 + assert response.json() == {"value": "spark_001"} + + def test_get_missing_key_returns_404(self, client: TestClient, create_task_instance: CreateTaskInstance): + ti = create_task_instance() + + response = client.get(_api_url(ti.id, "never_set")) + + assert response.status_code == 404 + assert response.json()["detail"]["reason"] == "not_found" + + def test_get_missing_ti_returns_404(self, client: TestClient): + response = client.get(_api_url(uuid4(), "any_key")) + + assert response.status_code == 404 + assert "Task instance" in response.json()["detail"]["message"] + + +class TestPutTaskState: + def test_put_creates_row(self, client: TestClient, create_task_instance: CreateTaskInstance): + ti = create_task_instance() + + response = client.put(_api_url(ti.id, "job_id"), json={"value": "spark_001"}) + + assert response.status_code == 204 + with create_session() as session: + row = session.scalar( + select(TaskStateModel).where( + TaskStateModel.dag_id == ti.dag_id, + TaskStateModel.run_id == ti.run_id, + TaskStateModel.task_id == ti.task_id, + TaskStateModel.key == "job_id", + ) + ) + assert row is not None + assert row.value == "spark_001" + + def test_put_overwrites_existing(self, client: TestClient, create_task_instance: CreateTaskInstance): + ti = create_task_instance() + client.put(_api_url(ti.id, "job_id"), json={"value": "spark_001"}) + + response = client.put(_api_url(ti.id, "job_id"), json={"value": "spark_002"}) + + assert response.status_code == 204 + assert client.get(_api_url(ti.id, "job_id")).json() == {"value": "spark_002"} + + def test_put_empty_body_returns_422(self, client: TestClient, create_task_instance: CreateTaskInstance): + ti = create_task_instance() + + response = client.put(_api_url(ti.id, "job_id"), json={}) + + assert response.status_code == 422 + + def test_put_extra_field_returns_422(self, client: TestClient, create_task_instance: CreateTaskInstance): + ti = create_task_instance() + + response = client.put(_api_url(ti.id, "job_id"), json={"value": "x", "extra": "y"}) + + assert response.status_code == 422 + + def test_put_null_value_returns_422(self, client: TestClient, create_task_instance: CreateTaskInstance): + ti = create_task_instance() + + response = client.put(_api_url(ti.id, "job_id"), json={"value": None}) + + assert response.status_code == 422 + + def test_put_missing_ti_returns_404(self, client: TestClient): + response = client.put(_api_url(uuid4(), "job_id"), json={"value": "x"}) + + assert response.status_code == 404 + + +class TestDeleteTaskState: + def test_delete_removes_key(self, client: TestClient, create_task_instance: CreateTaskInstance): + ti = create_task_instance() + client.put(_api_url(ti.id, "job_id"), json={"value": "spark_001"}) + + response = client.delete(_api_url(ti.id, "job_id")) + + assert response.status_code == 204 + assert client.get(_api_url(ti.id, "job_id")).status_code == 404 + + def test_delete_missing_key_is_noop(self, client: TestClient, create_task_instance: CreateTaskInstance): + ti = create_task_instance() + + response = client.delete(_api_url(ti.id, "never_existed")) + + assert response.status_code == 204 + + def test_delete_only_targets_one_key(self, client: TestClient, create_task_instance: CreateTaskInstance): + ti = create_task_instance() + client.put(_api_url(ti.id, "job_id"), json={"value": "a"}) + client.put(_api_url(ti.id, "checkpoint"), json={"value": "b"}) + + client.delete(_api_url(ti.id, "job_id")) + + assert client.get(_api_url(ti.id, "job_id")).status_code == 404 + assert client.get(_api_url(ti.id, "checkpoint")).json() == {"value": "b"} + + +class TestClearTaskState: + def test_clear_removes_all_keys(self, client: TestClient, create_task_instance: CreateTaskInstance): + ti = create_task_instance() + for k, v in [("job_id", "a"), ("checkpoint", "b"), ("retry_count", "c")]: + client.put(_api_url(ti.id, k), json={"value": v}) + + response = client.delete(_api_url(ti.id)) + + assert response.status_code == 204 + with create_session() as session: + count = session.scalar( + select(TaskStateModel) + .where(TaskStateModel.dag_id == ti.dag_id, TaskStateModel.task_id == ti.task_id) + .with_only_columns(TaskStateModel.key) + ) + assert count is None Review Comment: Good catch. Fixed to this with a more explicit check now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
