potiuk opened a new pull request, #26: URL: https://github.com/apache/airflow-steward/pull/26
## Summary Two pre-existing GNU-isms in `tools/agent-isolation/check-tool-updates.sh`'s socat upstream-lookup helper broke the script's socat reporting on macOS BSD coreutils. Both surfaced via `verify-secure-config` reporting `upstream lookup failed` for socat on the maintainer's macOS host. - **`tac`** — walks a sorted version list newest-to-oldest. Not in BSD coreutils. Folded into the preceding `sort` invocation: `sort -uV | tac` → `sort -uVr`. Identical output, one fewer external binary. - **`date -d "$mtime"`** — parses the server's `Last-Modified` header into an epoch. GNU-only; BSD `date(1)` only accepts `-jf <format>` for arbitrary parsing and does not understand RFC 2822 / RFC 7231 date strings. Delegated parsing to python3's `email.utils.parsedate_to_datetime`, which is the stdlib HTTP-date parser and is available everywhere python3 is. Same module is already used elsewhere in this script (the GitHub releases path). Verified end-to-end on macOS — `socat` now reports `✓ up to date` instead of `upstream lookup failed`. ## Test plan - [ ] `bash -n tools/agent-isolation/check-tool-updates.sh` (syntax check) passes. - [ ] Run end-to-end on macOS — socat row shows `✓ up to date` (or `upgrade candidate` if a newer aged-past-cooldown release exists at run time), not `upstream lookup failed`. - [ ] Run end-to-end on Linux too (CI ubuntu-latest) — socat row also resolves; no GNU-only fallback was relied on. - [ ] `prek run --files tools/agent-isolation/check-tool-updates.sh` clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
