bugraoz93 commented on PR #64943: URL: https://github.com/apache/airflow/pull/64943#issuecomment-4360711456
> > Hey @Prab-27, are you going to make this ready with passing CI? Please rebase and check CI for this. Also, it would be great to add a test as e2e that airflowctl imports well in the link below. We can create `airflowctl/` directory and also add integration tests that should be on the airflow core side. As this should be two-way tests, we should add to the e2e tests too Here https://github.com/apache/airflow/tree/main/airflow-e2e-tests/tests/airflow_e2e_tests > > > > Something like this > > > > https://github.com/apache/airflow/blob/3e5c2c59f1184ca7d38a030bd3045d665f5505fb/airflow-ctl-tests/tests/airflowctl_tests/conftest.py#L153-L170 > > > > We should start the AIP work. I can also finish this one from this PR if you cannot find time in the near future. This and creating the airflowctl client are sequential blockers to the entire migration. This is the entry point of the entire workstream, so please let me know how you would like to move forward > > Thanks @bugraoz93 ! I'll try to complete this as soon as possible Awesome, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
