bugraoz93 commented on code in PR #66179:
URL: https://github.com/apache/airflow/pull/66179#discussion_r3174546524
##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -592,6 +594,19 @@ def trigger(
except ServerResponseError as e:
raise e
+ def clear_task_instances(
Review Comment:
These makes everything under dags command, we need to create TasksOperations
similar to this class. Additionally this should create a image with static
checks.
##########
airflow-ctl/src/airflowctl/ctl/cli_config.py:
##########
@@ -268,6 +268,60 @@ def _load_help_texts_yaml() -> dict[str, dict[str, str]]:
help="The DAG ID of the DAG to pause or unpause",
)
+ARG_TASK_CLEAR_DAG_ID = Arg(
Review Comment:
We dont need to create these if it is in operations.py as it is created
automatically
##########
airflow-ctl/tests/airflow_ctl/ctl/commands/test_task_command.py:
##########
@@ -0,0 +1,134 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
Review Comment:
Tests should only be exists in tests_operations as it should only be in api/
side
##########
airflow-ctl/src/airflowctl/ctl/cli_config.py:
##########
@@ -403,6 +457,8 @@ def __init__(self, file_path: str | Path | None = None):
"_check_flag_and_exit_if_server_response_error",
# Excluding bulk operation. Out of scope for CLI. Should use
implemented commands.
"bulk",
+ # Hand-written `tasks clear`; nested ClearTaskInstancesBody is not
representable by CommandFactory.
+ "clear_task_instances",
Review Comment:
This doesn't needed as it will be auto generated
##########
airflow-ctl/src/airflowctl/ctl/commands/task_command.py:
##########
@@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import annotations
+
+import sys
+
+import rich
+
+from airflowctl.api.client import NEW_API_CLIENT, ClientKind,
ServerResponseError, provide_api_client
+from airflowctl.api.datamodels.generated import ClearTaskInstancesBody
+from airflowctl.ctl.console_formatting import AirflowConsole
+
+
+@provide_api_client(kind=ClientKind.CLI)
+def clear(args, api_client=NEW_API_CLIENT) -> None:
Review Comment:
Wince you created the method in the operations this also doesn't needed
similar to above comment as cli_config. The factory in cli config will generate
methods commands
##########
airflow-ctl/RELEASE_NOTES.rst:
##########
@@ -45,6 +45,7 @@ Bug Fixes
Improvements
^^^^^^^^^^^^
+- Add ``airflowctl tasks clear`` for clearing task instances in a DAG run
using the REST API (AIP-94, `#66176
<https://github.com/apache/airflow/issues/66176>`__)
Review Comment:
We are populating this when releasing. Could you please remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
