parkhojeong opened a new pull request, #66221:
URL: https://github.com/apache/airflow/pull/66221

    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   When manually selecting and copying text from the Rendered Templates tab, 
the pasted result contained an extra blank line . The copy button is 
unaffected.                                                                     
                                                                                
                                                                                
   
   - bug video
      
     
https://github.com/user-attachments/assets/ce494b8d-15ca-42c5-80b5-95303b2dc42b
   
   
   ## Root cause                                                                
                                                                                
                                                                                
                             
   During clipboard serialization, browsers reconstruct the copied text from 
that flex-based DOM structure rather than from the original source string, 
which can introduce unwanted line breaks and spacing in the pasted result.
   
   ```js
     // react-syntax-highlighter/src/highlight.js
     if (wrapLongLines & showLineNumbers) {                                     
                                                                                
                                                                                
                                   
       properties.style = { display: 'flex', ...properties.style };
     }                                                                          
                                                                                
                                                                                
                                   
   ```
   
   ## Fix
   Replacing the per-line flex layout with a plain block layout makes the 
rendered lines serialize more predictably during copy/paste, preserving the 
expected text structure.
   
   - fixed video
   
     
https://github.com/user-attachments/assets/5d32467f-c150-4afa-96fa-f4f1b23162b3
   
   
   *  closes: #66143
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to