[
https://issues.apache.org/jira/browse/AIRFLOW-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003807#comment-17003807
]
ASF GitHub Bot commented on AIRFLOW-6229:
-----------------------------------------
tooptoop4 commented on pull request #6918: [AIRFLOW-6229] SparkSubmitOperator
polls forever if status json can't…
URL: https://github.com/apache/airflow/pull/6918
… find driverState tag
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> SparkSubmitOperator polls forever if status json can't find driverState tag
> ---------------------------------------------------------------------------
>
> Key: AIRFLOW-6229
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6229
> Project: Apache Airflow
> Issue Type: New Feature
> Components: scheduler
> Affects Versions: 1.10.6
> Reporter: t oo
> Priority: Major
>
> You click ‘release’ on a new spark cluster while the prior spark cluster is
> processing some spark submits from airflow. Then airflow is never able to
> finish the sparksubmit task as it polls from status on the new spark cluster
> build which it can’t find status for as the submit happened on earlier spark
> cluster build….the status loop goes on forever
>
> [https://github.com/apache/airflow/blob/1.10.6/airflow/contrib/hooks/spark_submit_hook.py#L446]
> [https://github.com/apache/airflow/blob/1.10.6/airflow/contrib/hooks/spark_submit_hook.py#L489]
> It loops forever if it can’t find driverState tag in the json response, since
> the new build (pointed to by the released DNS name) doesn’t know about the
> driver submitted (in previously released build) then the 2nd response below
> does not contain the driverState tag.
>
> #response before clicking release on new build
> [ec2-user@reda ~]$
> curl +[http://dns:6066/v1/submissions/status/driver-20191202142207-0000]+
> { "action" : "SubmissionStatusResponse", "driverState" : "RUNNING",
> "serverSparkVersion" : "2.3.4", "submissionId" :
> "driver-20191202142207-0000", "success" : true, "workerHostPort" :
> "reda:31489", "workerId" : "worker-20191202133526-reda-31489"}
>
> #response after clicking release on new build
> [ec2-user@reda ~]$
> curl [http://dns:6066/v1/submissions/status/driver-20191202142207-0000]
> { "action" : "SubmissionStatusResponse", "serverSparkVersion" : "2.3.4",
> "submissionId" : "driver-20191202142207-0000", "success" : false
> }
>
>
> Definitely a defect in current code. Can fix this by modifying
> _process_spark_status_log function to set driver status to UNKNOWN if
> driverState is not in response after iterating all lines.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)