jscheffl commented on code in PR #64902:
URL: https://github.com/apache/airflow/pull/64902#discussion_r3175363091
##########
chart/values.yaml:
##########
@@ -3179,6 +3186,111 @@ statsd:
# Environment variables to add to StatsD container
env: []
+# OpenTelemetry Collector settings
+otelCollector:
+ # Send Airflow traces to the OTel Collector (sets [traces] otel_on).
+ tracesEnabled: true
+
+ # Send Airflow metrics to the OTel Collector (sets [metrics] otel_on and
disables statsd).
+ metricsEnabled: false
+
+ # Default value for the OTEL_METRIC_EXPORT_INTERVAL env var on Airflow pods.
+ # Interval (in milliseconds) at which the OTel SDK exports metrics to the
collector.
+ metricExportIntervalMs: 30000
+
+ # Override the OTel Collector config.yml. When set (non-empty), this string
replaces
+ # the chart's default collector config. The value is rendered with `tpl`, so
you can
+ # reference values like `{{ .Values.ports.otelCollectorOtlpHttp }}` or
+ # `{{ include "airflow.fullname" . }}` from inside the string. Leave empty
to use
+ # the chart default.
+ config: ""
Review Comment:
Should default really be an empty string or would `null`== `~` be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
