dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql
odbc hook
URL: https://github.com/apache/airflow/pull/6850#discussion_r361551629
##########
File path: setup.py
##########
@@ -275,6 +275,7 @@ def write_version(filename: str =
os.path.join(*["airflow", "git_version"])):
]
mssql = [
'pymssql~=2.1.1',
+ 'pyodbc',
Review comment:
i think it's better to be clear.
there are a number of different ways to connect to mssql in python, besides
pymssql (cTDS, pyodbc, turbodbc, BCP)
i think it makes sense to be clear in the hook name.
i think that operators may use one or another hook depending on the use
case. e.g. if you are going to store to parquet you might want to use
turbodbc. or if you are bulk output to csv you might consider BCP. executing
sql maybe just pyodbc.
these hooks don't exist now, but if we think ahead, perhaps it makes sense
to plan for their eventual possible inclusion.
that's my take, anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
