jscheffl commented on PR #65758: URL: https://github.com/apache/airflow/pull/65758#issuecomment-4364150028
> > > (...) breaks existing DAG setups when migrating to the Helm chart teams have to restructure their entire DAG paths just because of this hardcoded name > > > > > > Which case of migration and case where re-structuring you mean? > > @jscheffl The main issue is that many teams have existing setups (especially in local docker-compose) where DAGs are mounted directly without an extra subdirectory level when migrating to the Helm chart the forced repo/ path breaks things like absolute SQL file lookups and Python package imports Since git-sync natively supports the link flag for this exact purpose exposing it allows users to maintain path consistency across their environments without needing to refactor their code just to fit the chart's hardcoded naming. I heard your voice. I am not strictly against it but also am not supportive in this. I'd propose these users to adjust the path references to relative and not absolute path elements. There are ways to model Dags and references differently. In a normal voting this woul dbe a "0" vote. You might convince other maintainers for this fix. I will not block merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
