Re: [PR] Relax version checks for remote Edge Workers [airflow]

[via GitHub]

dheerajturaga commented on PR #66292:
URL: https://github.com/apache/airflow/pull/66292#issuecomment-4366443226

   > > @jscheffl, awesome! I think with globally distributed workers, this 
relaxing of the check is much needed. One nit , the version mismatch message in 
system status can feel like something is wrong with the worker. Instead, I 
think we should probably still show the worker as healthy but with a "!" so 
that theres something more than just being healthy . Something like this. What 
do you think?
   > 
   > Mhm, I was so far populating the status based on logging levels (INFO, 
WARNING, ERROR) and did not plan adding more status levels just for this case.
   > 
   > As a counter proposal how about (1) relaxing the text to still report 
"Healty" but highlight the version mismatch <img alt="image" width="236" 
height="49" 
src="https://private-user-images.githubusercontent.com/95105677/586845918-0beb093d-74e9-4f5f-b650-7eb14352551e.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Nzc4MjAwOTYsIm5iZiI6MTc3NzgxOTc5NiwicGF0aCI6Ii85NTEwNTY3Ny81ODY4NDU5MTgtMGJlYjA5M2QtNzRlOS00ZjVmLWI2NTAtN2ViMTQzNTI1NTFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA1MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNTAzVDE0NDk1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJmZDRkMTkwZTE5YjY4ZjdjZTQwYjdhZDA0NGNjMTNjMzZkZmZjMjM3NzdhMTA5MzBlOTMwZGFkNTVhMDBiZWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.bEafyB8LHu3aYNpB2wYBIyq4Slq0LmrQ2Tj5zpU1rmE";>
   > 
   > Or (2) also keep this informational and markt he version mismatch as info 
<img alt="image" width="238" height="49" 
src="https://private-user-images.githubusercontent.com/95105677/586846011-24bfd0f4-0e17-42d8-b419-66f015923d96.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Nzc4MjAwOTYsIm5iZiI6MTc3NzgxOTc5NiwicGF0aCI6Ii85NTEwNTY3Ny81ODY4NDYwMTEtMjRiZmQwZjQtMGUxNy00MmQ4LWI0MTktNjZmMDE1OTIzZDk2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA1MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNTAzVDE0NDk1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgyMDAzZDg1ODU3NTY0NWMwNzUzMWZjNWU0MjZhZTU5NzBlYWNmNDY5MmE1YWJiYjk3MjdlNDU5ZTA1NmRkMWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.BO5r6vbiZ0qOKKG0cyHw7aBdDh46-LGLts3_n_A-xMk";>
   > 
   > If you dislike my original I'd rather pick (1) to inform admins that there 
is work to do.
   
   1 is fine, it doesn't essentially need to be green. As long as it states its 
healthy we should be good


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org