anishgirianish commented on code in PR #62343:
URL: https://github.com/apache/airflow/pull/62343#discussion_r3178763816


##########
airflow-core/src/airflow/utils/db_cleanup.py:
##########
@@ -172,6 +172,7 @@ def readable_config(self):
     ),
     _TableConfig(table_name="deadline", recency_column_name="deadline_time", 
dag_id_column_name="dag_id"),
     _TableConfig(table_name="revoked_token", recency_column_name="exp"),
+    _TableConfig(table_name="connection_test_request", 
recency_column_name="created_at"),

Review Comment:
   Done, added `extra_filters` to `_TableConfig` and applied `state IN 
('success','failed')` so in-flight rows are never selectable for deletion 
regardless of retention. `recency_column` stays at `updated_at` to also respect 
the retention window from the last state change.



##########
airflow-core/src/airflow/utils/db_cleanup.py:
##########
@@ -172,6 +172,7 @@ def readable_config(self):
     ),
     _TableConfig(table_name="deadline", recency_column_name="deadline_time", 
dag_id_column_name="dag_id"),
     _TableConfig(table_name="revoked_token", recency_column_name="exp"),
+    _TableConfig(table_name="connection_test_request", 
recency_column_name="created_at"),

Review Comment:
   Done, added `extra_filters` to `_TableConfig` and applied `state IN 
('success','failed')` so in-flight rows are never selectable for deletion 
regardless of retention. `recency_column` stays at `updated_at` to also respect 
the retention window from the last state change. Thank you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to