leeyspaul commented on code in PR #66255:
URL: https://github.com/apache/airflow/pull/66255#discussion_r3179640817
##########
dev/breeze/src/airflow_breeze/utils/gh_workflow_utils.py:
##########
@@ -50,7 +50,7 @@ def tigger_workflow(workflow_name: str, repo: str, branch:
str = "main", **kwarg
command.extend(["-f", f"{key}={value}"])
console_print(f"[blue]Running command: {' '.join(command)}[/blue]")
- result = run_command(command, capture_output=True, check=False)
+ result = run_gh_command(command, capture_output=True)
Review Comment:
Fixed in the latest push by making `run_gh_command()` honor Breeze dry-run
before it calls `subprocess.run()`.
In dry-run mode it now returns a successful `CompletedProcess` immediately,
so `breeze --dry-run workflow-run ...` will not trigger `gh workflow run`. I
also added `test_run_gh_command_skips_subprocess_in_dry_run` to verify
`subprocess.run` is not called while dry-run is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
