amoghrajesh opened a new pull request, #66336:
URL: https://github.com/apache/airflow/pull/66336

   
   
    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   This is a follow up to: https://github.com/apache/airflow/pull/66073 to 
solve an inconsistency with the existing assets state API as it is today as 
pointed out in: 
https://github.com/apache/airflow/pull/66160#discussion_r3171192441
   
   
   ### What changed:
   
   Asset state routes were previously using a single set of endpoints with 
`?name=` as the identifier. This had two problems:
   
   1. `Asset.ref(uri="s3://...")` inlets produce `AssetUriRef` objects which 
only have `.uri`, not `.name` — the task runner can crash at context 
construction time with `AttributeError` before user code ran
   
   2. The shape was inconsistent with how the existing `/assets` execution API 
works (`/by-name` and `/by-uri` as separate endpoints)
   
   The routes are now split into `/by-name/` and `/by-uri/` sub-prefixes 
mirroring assets APIs. 
   
   ```python
   GET/PUT/DELETE  /state/asset/by-name/value?name=<n>&key=<k>
   DELETE          /state/asset/by-name/clear?name=<n>
   GET/PUT/DELETE  /state/asset/by-uri/value?uri=<u>&key=<k>
   DELETE          /state/asset/by-uri/clear?uri=<u>
   ```
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [x] Yes : claude sonnet 4.6
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to