amoghrajesh commented on code in PR #66002:
URL: https://github.com/apache/airflow/pull/66002#discussion_r3181484091
##########
airflow-core/tests/unit/serialization/test_dag_serialization.py:
##########
@@ -855,6 +857,20 @@ def validate_deserialized_task(
else:
assert serialized_task.resources == task.resources
+ # start_trigger_args: trigger_kwargs is kept as raw JSON after
deserialization;
+ # compare after deserializing both sides
+ if task.start_trigger_args is not None:
+ from airflow.serialization.serialized_objects import
BaseSerialization
+
+ s = serialized_task.start_trigger_args
+ o = task.start_trigger_args
+ assert s.trigger_cls == o.trigger_cls
+ assert s.next_method == o.next_method
Review Comment:
Good catch. Replaced both sides to be exact about comparison,
`_encode_start_trigger_args` serializes with `BaseSerialization` and
`_decode_start_trigger_args` keeps it raw, so the two sides should be identical
without any deserialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
