henry3260 commented on PR #63829: URL: https://github.com/apache/airflow/pull/63829#issuecomment-4373683402
> I am trying to understand (sorry for the late review). As far as I understand you're waiting regardless of `wait_for_completion` value right? What's `wait_for_completion` for now? first really appreciate your review and your time! `wait_for_completion=True` 1. `execute() `first defers to the trigger. 2. The trigger sends the refresh request and gets a `dataset_refresh_id`. 3. Control returns to handle_refresh(). 4. Because` wait_for_completion=True`, it defers a second time. 5. The second trigger keeps polling until the refresh completes or fails. 6. Finally, execution resumes in `execute_complete()`. `wait_for_completion=False` 1.` execute()` still first defers to the trigger. 2. The trigger sends the refresh request and gets a `dataset_refresh_id`. 3. Control returns to` handle_refresh()`. 4. Because `wait_for_completion=False`, it returns immediately there and does not defer a second time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
