Pyasma commented on code in PR #65469:
URL: https://github.com/apache/airflow/pull/65469#discussion_r3196233760
##########
airflow-core/src/airflow/serialization/definitions/param.py:
##########
@@ -22,12 +22,32 @@
import copy
from typing import TYPE_CHECKING, Any, Literal
+from isoduration import parse_duration
+from jsonschema import FormatChecker
+
from airflow.serialization.definitions.notset import NOTSET, is_arg_set
if TYPE_CHECKING:
from collections.abc import Iterator, Mapping
+def get_format_duration() -> FormatChecker:
Review Comment:
```
A format property checker.
JSON Schema does not mandate that the format property actually do any
validation. If validation is desired however, instances of this class can be
hooked into validators to enable format validation.
[FormatChecker](https://python-jsonschema.readthedocs.io/en/stable/api/#jsonschema.FormatChecker)
objects always return True when asked about formats that they do not know how
to validate.
To add a check for a custom format use the
[FormatChecker.checks](https://python-jsonschema.readthedocs.io/en/stable/api/#jsonschema.FormatChecker.checks)
decorator.
```
hey my bad this part confused me and i assumed duration/(all of the list)
was being treated as a custom format
I will make the required changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
