hasangzc opened a new pull request, #66479:
URL: https://github.com/apache/airflow/pull/66479
## Summary
- **OSSHook._get_client()**: The endpoint was hardcoded to the public URL
(`oss-{region}.aliyuncs.com`), making it impossible to use VPC/internal
endpoints (e.g. `oss-eu-central-1-internal.aliyuncs.com`). Now reads from
the connection's `extra` config with `endpoint` key, falling back to the
public default.
- **OSSTaskHandler._read()**: Called `self.oss_log_exists()` and
`self.oss_read()`
which don't exist on `OSSTaskHandler`. These methods live on
`OSSRemoteLogIO`
and must be accessed via `self.io`. This caused the webserver to fail
silently
when reading logs from OSS.
## Test plan
- [x] Added `test_get_client_uses_default_endpoint` - verifies default
endpoint behavior
- [x] Added `test_get_client_uses_custom_endpoint_from_connection` -
verifies custom endpoint from extra config
- [x] Added `test_read_calls_oss_methods_via_io` - verifies _read() uses
self.io
- [x] Added `test_read_falls_back_to_local_when_no_remote_log` - verifies
local fallback
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Cursor (Claude)
Generated-by: Cursor (Claude) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
