diogosilva30 commented on code in PR #65943:
URL: https://github.com/apache/airflow/pull/65943#discussion_r3201590972
##########
providers/edge3/src/airflow/providers/edge3/cli/worker.py:
##########
@@ -595,37 +659,65 @@ async def fetch_and_run_job(self) -> None:
self.background_tasks.add(task)
task.add_done_callback(self.background_tasks.discard)
- while job.is_running and results_queue.empty():
+ # Fork path: keep pushing logs while the child is running and has not
sent a result yet.
+ # Subprocess path: keep pushing logs while the child is running;
status comes from Popen.
+ while job.is_running and (results_queue is None or
results_queue.empty()):
Review Comment:
Good point, moving this logic to Job dataclass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
