orbisai0security commented on PR #66417: URL: https://github.com/apache/airflow/pull/66417#issuecomment-4412762553
✅ **Changes Applied** I've updated the code based on your feedback: The PR introduces a string concatenation with outer parentheses for `nested_groups_filter_str` in the `_ldap_get_nested_groups` method, instead of using an f-string. This causes `ruff format` to flag the file because: 1. The concatenation `(... + escaped_user_dn + ...)` wrapped in parentheses is inconsistent with the `filter_str` pattern used just a few lines above in `_search_ldap`, which already uses an f-string with the escaped variable. 2. Ruff's formatter expects consistent use of f-strings for string interpolation throughout the file. The fix converts the string concatenation back to an f-string using `escaped_user_dn` (already escaped, so no injection risk), making it consistent with the surrounding code style and passing pre-commit/ruff format checks. **Files modified:** - `providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py` The changes have been pushed to this PR branch. Please review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
