nailo2c commented on code in PR #65991:
URL: https://github.com/apache/airflow/pull/65991#discussion_r3213974539
##########
providers/apache/spark/tests/unit/apache/spark/hooks/test_spark_submit.py:
##########
@@ -1006,6 +1006,30 @@ def test_yarn_process_on_kill(self, mock_popen,
mock_renew_from_kt):
in mock_popen.mock_calls
)
+
@patch("airflow.providers.apache.spark.hooks.spark_submit.subprocess.Popen")
+ def
test_yarn_process_on_kill_kills_application_after_submit_process_exits(self,
mock_popen):
+ submit_process = MagicMock()
+ submit_process.poll.return_value = 0
+
Review Comment:
It seems to be the standard in the current Airflow test code. I learned it. 😄
https://github.com/apache/airflow/blob/d5efa6224c708c8250f756883f2ed19ae7fbc5af/.github/instructions/code-review.instructions.md?plain=1#L40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
