nailo2c commented on code in PR #66510:
URL: https://github.com/apache/airflow/pull/66510#discussion_r3214041110
##########
providers/google/src/airflow/providers/google/cloud/hooks/cloud_sql.py:
##########
@@ -852,12 +860,18 @@ def __init__(
self.use_proxy = self._get_bool(self.extras.get("use_proxy", "False"))
self.use_ssl = self._get_bool(self.extras.get("use_ssl", "False"))
self.use_iam = self._get_bool(self.extras.get("use_iam", "False"))
+ self.sql_proxy_enable_iam_login = self._get_bool(
+ self.extras.get("sql_proxy_enable_iam_login", "False")
+ )
self.sql_proxy_use_tcp =
self._get_bool(self.extras.get("sql_proxy_use_tcp", "False"))
self.sql_proxy_version = self.extras.get("sql_proxy_version")
self.sql_proxy_binary_path = sql_proxy_binary_path
if self.use_iam:
self.user = self._get_iam_db_login()
self.password =
self._generate_login_token(service_account=self.cloudsql_connection.login)
+ elif self.sql_proxy_enable_iam_login:
+ self.user = self._get_iam_db_login()
+ self.password = self.cloudsql_connection.password or ""
Review Comment:
good catch, fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
