Pranaykarvi commented on PR #64022: URL: https://github.com/apache/airflow/pull/64022#issuecomment-4414416662
Hi @amoghrajesh — both review comments have been addressed: 1. **Simplified double `try`** — `_execute()` now uses a single `try/except/finally` block with `_prev_ctx` restored at the end of the existing `finally` (after the cleanup logs and conditional `kill`), matching your suggested diff exactly. 2. **Symmetric client-context test** — Added `test_trigger_runner_sets_client_process_context` in `TestTriggererJobRunner` directly after `test_execute_sets_server_process_context`. It patches `arun` with an async `side_effect` to capture `_AIRFLOW_PROCESS_CONTEXT` during execution, then asserts it was `"client"` mid-run and restored to `None` after `run()` returns. Also rebased onto current `main` and resolved all conflicts. Thanks for the thorough review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
