Pranaykarvi commented on PR #63878: URL: https://github.com/apache/airflow/pull/63878#issuecomment-4414730225
Hi @SameerMesiah97 all review comments have been addressed: 1. **Redundant `try/except` in `configure_logging()`** (Copilot) — Removed the `try/except PermissionError` wrapper from `logging_config.py`. Since `init_log_folder()` already catches `PermissionError` internally and logs a warning, the wrapper was dead code that would never be hit. Reverted to a direct `return init_log_folder(...)` call. 2. **Redundant `continued_after_call` flag** (Copilot) — Removed the flag and its assertion from `test_init_log_folder_permission_error_logs_warning_and_continues`. The test already proves no exception propagated simply by reaching the `caplog.text` assertion. 3. **`caplog` style** (Copilot) — Added an explicit note in the file-level comment clarifying that most tests avoid `caplog` but this test intentionally uses it for stdlib logging capture on the `PermissionError` path. Also added a short docstring on the test itself. 4. **Rebased onto current `main`** — Resolved the conflict in `shared/logging/src/airflow_shared/logging/structlog.py` by keeping `PermissionError`-only (no broad `OSError`, per your earlier feedback), `mkdir(parents=True, exist_ok=True)`, and aligning with upstream's `_PatchedPath` so `init_log_folder` stays consistent with `init_log_file` and the Python 3.12–3.13 path parsing workaround. Marking as ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
