vincbeck commented on code in PR #66595:
URL: https://github.com/apache/airflow/pull/66595#discussion_r3220108258
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -760,11 +760,23 @@ def _create_workload(
render_log_fname: Callable[..., str],
session: Session,
) -> workloads.RunTrigger | None:
+ # aip-93
if trigger.task_instance is None:
+ asset_name: str | None = None
+ asset_uri: str | None = None
+
+ # aip-93: Is it always going to be the first asset from the
asset_watchers list?
+ if trigger.asset_watchers:
+ first_asset = trigger.asset_watchers[0].asset
+ asset_name = first_asset.name
+ asset_uri = first_asset.uri
Review Comment:
What `watched_asset_name` and `watched_asset_uri` represent? Why storing
only one whereas multiple assets can be associated to one trigger, why not
storing a list of assets?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
