o-nikolas commented on code in PR #66491:
URL: https://github.com/apache/airflow/pull/66491#discussion_r3222057051
##########
airflow-core/src/airflow/dag_processing/manager.py:
##########
@@ -753,7 +782,9 @@ def _refresh_dag_bundles(self, known_files: dict[str,
set[DagFileInfo]]):
if bundle.supports_versioning:
# we will also check the version of the bundle to see if
another DAG processor has seen
# a new version
- pre_refresh_version = self._bundle_versions.get(bundle.name)
or bundle.get_current_version()
+ pre_refresh_version = self._bundle_versions.get(bundle.name)
+ if pre_refresh_version is None:
+ pre_refresh_version, _ =
self._unpack_bundle_version(bundle.get_current_version(), bundle)
Review Comment:
It's not too common to comment on code delta. Any future reader won't know
what it was in the past so it isn't very helpful context, IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
