jscheffl opened a new pull request, #66735: URL: https://github.com/apache/airflow/pull/66735
Following-up on the PR by @ashb in https://github.com/apache/airflow/pull/66037 I realized the same shotcoming with the change as some (my local) users complained about in Airflow 2.x as well: If the task fails the Exception details are swallowed/hidden in the post execution block. Experienced users complianed they always need to click to un-fold to see details and in-experienced users did not see any error and wondered why task was failing. Before (so after @ashb added folding for Pre/Post task (THANKS!!!): Successful task: <img width="656" height="170" alt="image" src="https://github.com/user-attachments/assets/c4a488f9-f5ba-4f41-acf7-c5edb9f84584"; /> Failed task: <img width="557" height="330" alt="image" src="https://github.com/user-attachments/assets/d6439859-942b-49d7-a0ed-8f1a4eea40fb"; /> Need to un-fold to see the error actually: <img width="1120" height="597" alt="image" src="https://github.com/user-attachments/assets/a8d4c8a5-603d-40b8-aac1-e05220d9acff"; /> With this PR the exception in case of task failure is moved above the Post-Execution log group: <img width="1130" height="535" alt="image" src="https://github.com/user-attachments/assets/0f29905b-4698-4aca-9a09-e6cdec955f3e"; /> (So no un-folding of group needed, only "boring" logs below exception): <img width="1110" height="592" alt="image" src="https://github.com/user-attachments/assets/5575f1da-8c82-4784-a8cd-8fb0b97b8c11"; /> I admit the code is not as elegant as before with a single group but now scattered across multiple different exception catching blocks. Ideas for more elegant placing welcome. But UX should be good first (over code beautiness) Note: Just adjusted primary code, will fix pytests tomorrow but leave PR here for catching comments on change. --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [ ] Yes (please specify the tool below) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
