shahar1 commented on code in PR #61949:
URL: https://github.com/apache/airflow/pull/61949#discussion_r3223660793
##########
providers/google/src/airflow/providers/google/cloud/hooks/gcs.py:
##########
@@ -347,6 +344,16 @@ def download(
blob = bucket.blob(blob_name=object_name,
chunk_size=chunk_size)
if filename:
+ blob.reload(timeout=timeout)
Review Comment:
1. Can we extract the `blob.reload(...)` outside the retry loop?
2. Could you please add a flag (+docstring) for checking disk space
(default: `False`), as it is an extra API call which might not be relevant when
there are no storage limitations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
