shivaam commented on code in PR #63657:
URL: https://github.com/apache/airflow/pull/63657#discussion_r3223886555
##########
providers/amazon/src/airflow/providers/amazon/aws/executors/ecs/utils.py:
##########
@@ -27,22 +27,26 @@
from collections import defaultdict
from collections.abc import Callable, Sequence
from dataclasses import dataclass
-from typing import TYPE_CHECKING, Any
+from typing import TYPE_CHECKING, Any, TypeAlias
from inflection import camelize
from airflow.providers.amazon.aws.executors.utils.base_config_keys import
BaseConfigKeys
+from airflow.providers.amazon.version_compat import AIRFLOW_V_3_3_PLUS
from airflow.utils.state import State
if TYPE_CHECKING:
- from airflow.providers.amazon.version_compat import AIRFLOW_V_3_3_PLUS
-
if AIRFLOW_V_3_3_PLUS:
from airflow.executors.workloads.types import WorkloadKey
else:
from airflow.models.taskinstance import TaskInstanceKey as WorkloadKey
# type: ignore[assignment]
-CommandType = Sequence[str]
+if AIRFLOW_V_3_3_PLUS:
+ from airflow.executors.workloads import ExecuteCallback, ExecuteTask
+
+ CommandType: TypeAlias = Sequence[str] | Sequence[ExecuteTask |
ExecuteCallback]
Review Comment:
@ferruzzi made these changes which helped in removing all the ignore
statements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
