yuseok89 commented on code in PR #66717:
URL: https://github.com/apache/airflow/pull/66717#discussion_r3226871364
##########
airflow-core/src/airflow/ui/src/queries/useTrigger.ts:
##########
@@ -48,9 +48,15 @@ export const useTrigger = ({ dagId, onSuccessConfirm }: {
dagId: string; onSucce
});
onSuccessConfirm();
- // Only redirect if we're already on the dag page
+ // Only redirect if we're already on the dag page.
+ // Preserve search params so layout state (Grid limit, filters) survives
the navigation.
if (selectedDagId === dagRun.dag_id) {
- void
Promise.resolve(navigate(`/dags/${dagRun.dag_id}/runs/${dagRun.dag_run_id}`));
+ void Promise.resolve(
+ navigate({
+ pathname: `/dags/${dagRun.dag_id}/runs/${dagRun.dag_run_id}`,
+ search: globalThis.location.search,
+ }),
Review Comment:
Thanks for the detailed read.
I was focused on the fix itself and missed both angles.
Pushed a follow-up commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
