seruman commented on code in PR #65310:
URL: https://github.com/apache/airflow/pull/65310#discussion_r3228065797
##########
airflow-core/tests/unit/dag_processing/test_collection.py:
##########
@@ -1137,6 +1137,16 @@ def test_max_active_runs_explicit_value_is_used(self,
testing_dag_bundle, sessio
orm_dag = session.get(DagModel, "dag_max_runs")
assert orm_dag.max_active_runs == 3
+ def test_max_active_runs_equal_to_schema_default_not_overridden_by_conf(
+ self, testing_dag_bundle, session, dag_maker
+ ):
+ with conf_vars({("core", "max_active_runs_per_dag"): "1"}):
+ with dag_maker("dag_max_runs_schema_default", schedule=None,
max_active_runs=16) as dag:
+ ...
+ update_dag_parsing_results_in_db("testing", None, [dag], {}, 0.1,
set(), session)
+ orm_dag = session.get(DagModel, "dag_max_runs_schema_default")
+ assert orm_dag.max_active_runs == 16
Review Comment:
PTAL
##########
airflow-core/tests/unit/serialization/test_dag_serialization.py:
##########
@@ -333,6 +333,11 @@ def _operator_defaults(overrides):
},
],
"params": [],
+ "catchup": False,
+ "disable_bundle_versioning": False,
+ "max_active_runs": 16,
+ "max_active_tasks": 16,
+ "max_consecutive_failed_dag_runs": 0,
Review Comment:
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
