ephraimbuddy commented on code in PR #66773:
URL: https://github.com/apache/airflow/pull/66773#discussion_r3228063001


##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -2938,7 +2944,10 @@ def _find_task_instances_without_heartbeats(self, *, 
session: Session) -> list[T
                 .join(DM, TI.dag_id == DM.dag_id)
                 .where(
                     TI.state.in_((TaskInstanceState.RUNNING, 
TaskInstanceState.RESTARTING)),
-                    TI.last_heartbeat_at < limit_dttm,
+                    or_(
+                        TI.last_heartbeat_at < limit_dttm,

Review Comment:
   Can you walk me through how `TI.last_heartbeat_at ` can be null for a 
running task as I thought it's set here: 
https://github.com/apache/airflow/blob/07bf075b94fb8679ac3f83b02c04226e5696fe0b/airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py#L237



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to