dondaum commented on code in PR #66702: URL: https://github.com/apache/airflow/pull/66702#discussion_r3229433209
########## task-sdk/src/airflow/sdk/execution_time/callback_supervisor.py: ########## @@ -66,6 +69,7 @@ class _BundleInfoLike(Protocol): __all__ = ["CallbackSubprocess", "supervise_callback"] log: FilteringBoundLogger = structlog.get_logger(logger_name="callback_supervisor") +UNUSUAL_MODULE_PREFIX = "unusual_prefix_" Review Comment: I guess finding a suitable location for this is even harder than finding a good name 😃 I have three suggestions: 1) We could place it at `shared/module_loading/src/airflow_shared/module_loading/dag_file.py`. 2) We could place it at `shared/configuration/src/airflow_shared/configuration/dag_file.py`. 3) We could create a new shared package—perhaps `shared/file` (though that might be a bit overkill just to move a small global variable). I’m leaning towards Option 2. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
