o-nikolas commented on code in PR #66576: URL: https://github.com/apache/airflow/pull/66576#discussion_r3230204822
########## providers/amazon/src/airflow/providers/amazon/aws/operators/athena_spark.py: ########## @@ -0,0 +1,229 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +AthenaSparkOperator for running Apache Spark calculations in Amazon Athena. +""" + +from __future__ import annotations + +import time +from collections.abc import Sequence +from typing import TYPE_CHECKING, Any + +from airflow.providers.amazon.aws.hooks.athena import AthenaHook +from airflow.providers.amazon.aws.operators.base_aws import AwsBaseOperator +from airflow.providers.amazon.aws.utils.mixins import aws_template_fields +from airflow.providers.common.compat.sdk import AirflowException + +if TYPE_CHECKING: + from airflow.sdk import Context + + +class AthenaSparkOperator(AwsBaseOperator[AthenaHook]): + """ + Run an Apache Spark calculation in an Amazon Athena session. + + Submits a calculation (e.g. PySpark code) via the Athena API, polls until + the calculation reaches a terminal state (COMPLETED, FAILED, or CANCELED), + and returns execution metadata. + + .. seealso:: + - :class:`airflow.providers.amazon.aws.hooks.athena.AthenaHook` + - `Athena for Apache Spark + <https://docs.aws.amazon.com/athena/latest/ug/notebooks-spark-api-list.html>`__ + + :param session_id: The Athena session ID in which to run the calculation. (templated) + :param code_block: The calculation code (e.g. PySpark) to execute. (templated) + :param description: Optional description of the calculation. + :param client_request_token: Optional idempotency token for the submission. + :param poll_interval: Seconds to wait between status checks. Default 30. + :param max_polling_attempts: Maximum number of polling attempts before timing out. + To limit total task time, use execution_timeout on the task as well. Review Comment: The majority of the Amazon provider uses `max_attempts`, please use that throughout this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
