o-nikolas commented on code in PR #66549: URL: https://github.com/apache/airflow/pull/66549#discussion_r3230407737
########## providers/amazon/tests/system/amazon/aws/example_opensearch_serverless.py: ########## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from datetime import datetime + +from airflow.providers.amazon.aws.operators.opensearch_serverless import ( + OpenSearchServerlessCreateCollectionOperator, +) +from airflow.providers.common.compat.sdk import DAG, chain + +from system.amazon.aws.utils import ENV_ID_KEY, SystemTestContextBuilder +from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS + +if AIRFLOW_V_3_0_PLUS: + from airflow.sdk import TriggerRule, task +else: + from airflow.decorators import task # type: ignore[attr-defined,no-redef] + from airflow.utils.trigger_rule import TriggerRule # type: ignore[no-redef,attr-defined] + +DAG_ID = "example_opensearch_serverless" + +sys_test_context_task = SystemTestContextBuilder().build() + + +@task(trigger_rule=TriggerRule.ALL_DONE) +def delete_collection(collection_id: str): + import boto3 + + boto3.client("opensearchserverless").delete_collection(id=collection_id) + + +with DAG( + dag_id=DAG_ID, + schedule=None, + start_date=datetime(2024, 1, 1), + catchup=False, +) as dag: + test_context = sys_test_context_task() + env_id = test_context[ENV_ID_KEY] + collection_name = f"{env_id}-collection" + + # [START howto_operator_opensearch_serverless_create_collection] + create_collection = OpenSearchServerlessCreateCollectionOperator( + task_id="create_collection", + collection_name=collection_name, + collection_type="SEARCH", + ) + # [END howto_operator_opensearch_serverless_create_collection] + + chain( + test_context, + create_collection, + delete_collection(create_collection.output), Review Comment: Please add the `TEST SETUP`, `TEST BODY` and `TEST TEARDOWN` comments. I know it seems silly for only three steps, but the consistency is nice and as the test grows it helps. I thought you instructed your agent to remember this point? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
