amoghrajesh commented on code in PR #66463: URL: https://github.com/apache/airflow/pull/66463#discussion_r3231437569
########## airflow-core/src/airflow/cli/commands/state_store_command.py: ########## @@ -0,0 +1,50 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import logging + +from airflow.state import get_state_backend +from airflow.state.metastore import MetastoreStateBackend + +log = logging.getLogger(__name__) + +# Other state operations (list, get, delete per key) will be added here in the future. + + +def cleanup(args) -> None: + """Remove expired task state rows via the configured state backend.""" + backend = get_state_backend() + + if args.dry_run: + if isinstance(backend, MetastoreStateBackend): + summary = backend._summary_dry_run_() + expired = summary["expired"] + if not expired: + print("Nothing to delete.") + return + print(f"Would delete {len(expired)} task state row(s):\n") + for dag_id, run_id, task_id, map_index, key in expired: + print( + f" Dag {dag_id!r}, run {run_id!r}, task {task_id!r}, map_index {map_index!r}, key {key!r}" + ) + else: + print("Custom backend configured — cannot preview rows.") Review Comment: Good thought, making `dry_run_summary()` part of `BaseStateBackend` would clean up the `isinstance` check and give custom server-side backends a hook to implement their own preview. That said, the current design is intentional: the return format ({"expired": list} of DB rows) is specific to `MetastoreStateBackend` storage model. A Redis or S3 backend would likely have nothing meaningful to report here, or a completely different representation. I'd keep it scoped to `MetastoreStateBackend` for now and track it as a need-to-do basis because I do not know if the CLI cleanup is ideal to cleanup custom backends (i think not). If custom backends ever need dry-run support, we can design the interface with their semantics in mind rather than retrofitting the DB row format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
