rahul-madaan opened a new pull request, #66844:
URL: https://github.com/apache/airflow/pull/66844
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
AthenaSQLHook (PyAthena-based SQL hook for Amazon Athena) had no
OpenLineage
methods, so SQL executed through it via SQLExecuteQueryOperator or the
common
SQL machinery did not emit input/output dataset lineage.
This adds the three standard OpenLineage hook methods, following the
pattern
used by TrinoHook and PostgresHook:
- `get_openlineage_database_info` — returns DatabaseInfo with
`scheme="awsathena"` and `authority="athena.{region}.amazonaws.com"`,
matching the namespace already emitted by AthenaOperator
(`operators/athena.py:get_openlineage_dataset`). The default catalog is
`AwsDataCatalog`, overridable via the connection's `extra.catalog`.
- `get_openlineage_database_dialect` — returns `"trino"`. Athena's SQL
engine
v3 is Trino-based, and OpenLineage has no separate "presto" dialect
parser.
- `get_openlineage_default_schema` — returns the connection's schema, or
`"default"` as Athena's fallback database.
No new unit tests added — this matches the convention used by TrinoHook,
PostgresHook, MySQLHook and MsSqlHook, none of which have dedicated unit
tests for these trivial wrapper methods. Existing AthenaSQLHook tests
continue to pass.
related: #64807, #64513
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: Claude Opus 4.7 following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
