Sathvik-Chowdary-Veerapaneni commented on PR #63692: URL: https://github.com/apache/airflow/pull/63692#issuecomment-4443405014
Thanks for the reminder. I pushed updates addressing the open review comments by narrowing the PR back to the core DAG callback fix: - Removed the extra bundle-name guard in `DagFileProcessorManager`; fetched callbacks are already scoped by the bundle query. - Changed the scheduler callback request log from `info` to `debug`. - Removed the broad fallback around `DagRunContext`; callbacks now require the full server context instead of being sent with partial/minimal context. - Removed the fallback-specific regression test. I also updated the PR description to remove the stale fallback/logging notes. Verified locally in a clean worktree: - `airflow-core/tests/unit/models/test_dagrun.py::TestDagRun::test_dagrun_update_state_with_handle_callback_failure` - `airflow-core/tests/unit/dag_processing/test_manager.py::TestDagFileProcessorManager::test_fetch_callbacks_ignores_other_bundles` Both passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
