hkc-8010 commented on PR #66696:
URL: https://github.com/apache/airflow/pull/66696#issuecomment-4443472117

   Both issues from the code review above have been addressed in the latest 
push (commit 2ff659c1173):
   
   **Issue 1 — lower-bound `now()` guard removed**
   
   Lower bounds now use `or_(col >= x, col.is_(None))` with no `func.now()` 
call. A task with NULL `start_date` passes any lower-bound filter 
unconditionally, which is the correct semantic: a not-yet-started task will 
eventually start at or after any past bound.
   
   **Issue 2 — factory dispatch fixed for aliased filter names**
   
   The dispatch condition changed from `filter_name in ("start_date", 
"end_date")` to `(attribute_name or filter_name) in ("start_date", 
"end_date")`. Callers that pass an aliased `filter_name` with 
`attribute_name="start_date"` or `attribute_name="end_date"` (e.g. the DAGs 
endpoint using `"dag_run_end_date"`) now correctly receive 
`NullableDatetimeRangeFilter` rather than a plain `RangeFilter`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to