ashb commented on PR #66699:
URL: https://github.com/apache/airflow/pull/66699#issuecomment-4449104957

   I think we should change the Exec API interface -- rather than sending 
retention_days to the server, lets make the Exec API endpoint(s?) take an 
`expires_at` as a DateTime and do any calculation on the client side. This is 
more expressive, and also lets us much more easily have expiry of less than 1 
day. (For instance, for dags that run every 5 or 30 min, 1 day can still be a 
"long time").
   
   I'm wondering if instead of retention_days being a) days, b) an integer, it 
should be a timeinterval? WDYT?
   
   It could be `retention: int | timedelta | None = None` -- int = days, or a 
timedelta. This might be "too magic", but I think we already have a similar 
convention for this int=days somewhere in Airflow?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to