bbovenzi commented on code in PR #66945:
URL: https://github.com/apache/airflow/pull/66945#discussion_r3243156445
##########
airflow-core/src/airflow/ui/src/pages/DagsList/DagCard.tsx:
##########
@@ -51,9 +51,9 @@ export const DagCard = ({ dag }: Props) => {
<HStack>
<Tooltip content={dag.description}
disabled={!Boolean(dag.description)}>
<Link asChild color="fg.info" fontWeight="bold">
- <RouterLink data-testid="dag-id" to={`/dags/${dag.dag_id}`}>
+ <ReactRouterLink data-testid="dag-id" to={`/dags/${dag.dag_id}`}>
{dag.dag_display_name}
- </RouterLink>
+ </ReactRouterLink>
</Link>
Review Comment:
This one wasn't converted correctly
##########
airflow-core/src/airflow/ui/src/pages/DagsList/DagCard.tsx:
##########
@@ -83,20 +83,18 @@ export const DagCard = ({ dag }: Props) => {
</Stat>
<Stat data-testid="latest-run"
label={translate("dagDetails.latestRun")}>
{latestRun ? (
- <Link asChild color="fg.info">
- <RouterLink
to={`/dags/${latestRun.dag_id}/runs/${latestRun.run_id}`}>
- <DagRunInfo
- endDate={latestRun.end_date}
- logicalDate={latestRun.logical_date}
- runAfter={latestRun.run_after}
- startDate={latestRun.start_date}
- state={latestRun.state}
- />
- {isStatePending(latestRun.state) && !dag.is_paused &&
Boolean(refetchInterval) ? (
- <Spinner />
- ) : undefined}
- </RouterLink>
- </Link>
+ <RouterLink
to={`/dags/${latestRun.dag_id}/runs/${latestRun.run_id}`}>
Review Comment:
Just rename this one back to `Link`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
