ColtenOuO opened a new pull request, #66967: URL: https://github.com/apache/airflow/pull/66967
`Pool.create_or_update_pool()` and `Pool.delete_pool()` in `airflow-core/src/airflow/models/pool.py` declared `session` as a positional parameter and called `session.commit()` explicitly. Both patterns violate the project convention stated in `CLAUDE.md`: > In `airflow-core`, functions with a `session` parameter must not call > `session.commit()`. Use keyword-only `session` parameters. This PR fixed the violation. ## Test plan: - [X] `breeze run pytest airflow-core/tests/unit/models/test_pool.py -v` — 22 passed - [X] `breeze run uv run --project airflow-core mypy airflow-core/src/airflow/models/pool.py` — no issues - [X] `uvx ruff format` + `uvx ruff check` — clean -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
