This is an automated email from the ASF dual-hosted git repository.
shahar1 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 767b72b5652 Fix no-op equality checks in Vertex AI trigger tests
(#66894)
767b72b5652 is described below
commit 767b72b5652c6785f40623d76e1dd46185ebb9db
Author: yukitomo <[email protected]>
AuthorDate: Fri May 15 14:00:31 2026 +0900
Fix no-op equality checks in Vertex AI trigger tests (#66894)
Four serialization tests in test_vertex_ai.py compared actual to
expected data with a bare `actual_data == expected_data` expression
instead of `assert actual_data == expected_data`, so the comparisons
silently evaluated and discarded their result and the tests passed
regardless of correctness. Add the missing `assert` so the checks
actually validate the serialized trigger payloads.
---
.../google/tests/unit/google/cloud/triggers/test_vertex_ai.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
a/providers/google/tests/unit/google/cloud/triggers/test_vertex_ai.py
b/providers/google/tests/unit/google/cloud/triggers/test_vertex_ai.py
index 4a473601fc7..1fb59d6ea6b 100644
--- a/providers/google/tests/unit/google/cloud/triggers/test_vertex_ai.py
+++ b/providers/google/tests/unit/google/cloud/triggers/test_vertex_ai.py
@@ -414,7 +414,7 @@ class TestRunPipelineJobTrigger:
"impersonation_chain": TEST_IMPERSONATION_CHAIN,
},
)
- actual_data == expected_data
+ assert actual_data == expected_data
@pytest.mark.asyncio
async def test_async_hook(self, run_pipeline_job_trigger):
@@ -554,7 +554,7 @@ class TestCustomTrainingJobTrigger:
"impersonation_chain": TEST_IMPERSONATION_CHAIN,
},
)
- actual_data == expected_data
+ assert actual_data == expected_data
@pytest.mark.parametrize(
"pipeline_state_value",
@@ -704,7 +704,7 @@ class TestCustomContainerTrainingJobTrigger:
"impersonation_chain": TEST_IMPERSONATION_CHAIN,
},
)
- actual_data == expected_data
+ assert actual_data == expected_data
@pytest.mark.parametrize(
"pipeline_state_value",
@@ -859,7 +859,7 @@ class TestCustomPythonPackageTrainingJobTrigger:
"impersonation_chain": TEST_IMPERSONATION_CHAIN,
},
)
- actual_data == expected_data
+ assert actual_data == expected_data
@pytest.mark.parametrize(
"pipeline_state_value",
