23tae commented on code in PR #66856:
URL: https://github.com/apache/airflow/pull/66856#discussion_r3246496590
##########
task-sdk/src/airflow/sdk/timezone.py:
##########
@@ -22,6 +22,7 @@
coerce_datetime,
convert_to_utc,
datetime,
+ from_timestamp,
Review Comment:
Thanks for the suggestion.
I tried to use existing SDK utilities like `coerce_datetime` to avoid the
expansion, but I noticed there's already a linter rule in `pyproject.toml`
(line 886) that explicitly recommends `airflow.sdk.timezone.from_timestamp`
over `pendulum.from_timestamp`.
It seems the intention was for providers to use this function, but it was
just missing from the SDK's public `__all__`. So I think adding it there is the
right fix rather than working around it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
